•  realharo   ( @realharo@lemm.ee ) 
          link
          fedilink
          11
          edit-2
          10 months ago

          Not like that, lol

          Just saying, instead of this monstrosity

          CreateOrderRequest(user,
                             productDetails,
                             pricingCalculator,
                             order => order.internalNumber)
          

          Just use

          CreateOrderRequest(
              user,
              ...
          

          Putting the first argument on a separate line.

          Same if you have an if using a bunch of and (one condition per line, first one on a new line instead of same line as the if) and similar situations.

    • Then you lose the benefit of tabs: you can’t adjust the tab width without destroying alignment. So you end up with a confusing mix of characters for no benefit.

      Mixing them is the worst option.

      •  Faresh   ( @Faresh@lemmy.ml ) 
        link
        fedilink
        English
        5
        edit-2
        10 months ago

        The opposite is true, though. If you use tabs for indentation and spaces for alignment, you can adjust the tab width without destroying alignment. That’s the big benefit of the tabs-for-indentation-spaces-for-alignment mix.

        You can’t do that with only tab characters, you can’t even align stuff with tabs because it has variable width.

      • You might not understand how to do it properly so here’s the idea:

        Tabs will let you reach the indentation level of the current block, then from here, you’ll use spaces to align stuff property. Here’s an example, where >••• are tabs (I’m exaggerating alignment for the sake of the example) :

        >•••if (condition1 == true
        >••• || condition2 != false)
        >•••{
        >•••>•••struct ident people[] = [
        >•••>•••>•••{
        >•••>•••>•••>•••.name   = "bob",
        >•••>•••>•••>•••.pubkey = "value1",
        >•••>•••>•••},
        >•••>•••>•••{
        >•••>•••>•••>•••.name   = "alice",
        >•••>•••>•••>•••.pubkey = "value2",
        >•••>•••>•••}
        >•••>•••];
        >•••>•••secureConnection(people[0].name, people[0].pubkey,
        >•••>•••                 people[1].name, people[1].pubkey,
        >•••>•••                 CRYPTO_ALGO_DEFAULT);
        >•••}
        

        As you can see, everything will stay correctly aligned as long as it’s within the same block.

      • You’re confusing using tabs for indentation and spaces for alignment with using tabs and spaces for indentation. This means each line starts with tabs. Next you optionally have spaces for alignment with previous lines. Then you have content (like code or comments). Because you never have a tab following a space the alignment is never destroyed by adjusting how wide a tabstop is.

    • I used to think this way, at least when writing C++. But it’s objectively harder to do and convince other people to follow, especially if they can’t be bothered to change their environment to display tabs and spaces differently. It’s a losing battle so now I just do spaces when working with other people

    • It’s hard to do this consistently (especially in a team) because people might (and statistically in a large enough project, will) use the tab key for alignment since it’s faster than pressing space, or just be confused about what whitespace is tabs and what is space. Just using space everywhere is idiot proof and requires no work to micromanage. The only way to use tabs is to not align at all.

      • I agree that it’s hard, but not impossible. This usually boils down to how Nazi people are when merging code. In a corporate environment, nobody gives a damn so yeah you gotta use whatever you want because there are already different indentation systems within the same file anyway :)

        But hey, you gotta live by the changes you want to see happen, so I personally put a lot of effort in formatting my code regardless.