OK, fair enough. What should it say instead? Just omit the mention of DateTime? I used it because it’s literally the only way to derive(Deserialize) in Chrono in a way that gives you DST aware arithmetic on the result without getting time zone information via some out-of-band mechanism.
Actually, I may have been too finicky about this myself.
Since I often write my own wrapping serialization code for use with non-serde formats, I didn’t realize that chrono::DateTime wasn’t serde-serializable, even with the serde feature enabled for both crates. That’s where the biggest problem probably lies.
In the example, using chorono_tz::Tz, and only converting to-be-serialized values to FixedOffset would probably put better focus on where the limitations/issues actually lie.
I think the comparison is a bit more muddied now and probably worse overall to be honest. Maybe removing DateTime is the right thing to do. I’ll think on it.
It’s a subtle comparison to make… Probably most people don’t even realize that they’re doing the wrong thing.
OK, fair enough. What should it say instead? Just omit the mention of
DateTime? I used it because it’s literally the only way toderive(Deserialize)in Chrono in a way that gives you DST aware arithmetic on the result without getting time zone information via some out-of-band mechanism.Actually, I may have been too finicky about this myself.
Since I often write my own wrapping serialization code for use with non-serde formats, I didn’t realize that
chrono::DateTimewasn’t serde-serializable, even with theserdefeature enabled for both crates. That’s where the biggest problem probably lies.In the example, using
chorono_tz::Tz, and only converting to-be-serialized values toFixedOffsetwould probably put better focus on where the limitations/issues actually lie.OK, I’ve beefed that example up a little bit: https://github.com/BurntSushi/jiff/commit/08dfdde204c739e38147faf70b648e2d417d1c2e
I think the comparison is a bit more muddied now and probably worse overall to be honest. Maybe removing
DateTimeis the right thing to do. I’ll think on it.It’s a subtle comparison to make… Probably most people don’t even realize that they’re doing the wrong thing.