Merged
But thanks for keeping my phone up to date, it is appreciated ♥
- infinitevalence ( @infinitevalence@discuss.online ) English9•8 months ago
Same, I run 3 devices all on Lineage and its great. Who know that you could still get updates and support for a device from 10 years ago, suck on that apple.
- DreadPotato ( @DreadPotato@sopuli.xyz ) 1•8 months ago
It’s just kind of sucks that updates consistently breaks banking apps and other stuff relying of passing safetynet. Every time I update I have to do the Magisk workaround again which is really annoying.
- aMockTie ( @aMockTie@beehaw.org ) 25•8 months ago
Why did they submit this as a pull request in the first place? Just commit it to a WIP branch until it’s ready to merge. Am I missing something?
- brisk ( @brisk@aussie.zone ) 30•8 months ago
Probably to get some other benefitof the PR system, such as CI tests
Does gerrit have a draft state? In azure devops you can mark PR as draft , won’t trigger any builds but you can still start them manually
- beeng ( @beeng@discuss.tchncs.de ) 4•8 months ago
manually
This is probably why the dev created a PR, less clicks
- sf1tzp ( @sf1tzp@programming.dev ) 2•8 months ago
I don’t remember if it did when I used it. Our convention was to -2 your own change until it was ready to go 😅
- NotSteve_ ( @NotSteve_@lemmy.ca ) 7•8 months ago
I do this often. It’s useful if you want to send it to your coworker for some early feedback or as others have said, have the CI run
- Dr. Jenkem ( @DrJenkem@lemmy.blugatch.tube ) English4•8 months ago
It’s been a while since I’ve worked with AOSP, but I had always understood it to be some weird shit with Google’s internal processes. The “do not merge” commits are all over the AOSP, or at least they used to be.
- ryannathans ( @ryannathans@aussie.zone ) 8•8 months ago
There are a LOT of these in lineage repos. There must be a reason
- xia ( @xia@lemmy.sdf.org ) English3•8 months ago
Maybe they dont use squash merges, so all the intermediate commits remain on-chain?
- NegativeLookBehind ( @NegativeLookBehind@kbin.social ) 5•8 months ago
Nice