Not to throw shade, just wishing that somebody here can understand. Whenever an input is reasonably long, an analyzing function will crash, and this PR aims to fix that with a mechanism that contradicts the maintainer’s understanding while a similar C implementation does not need this fix. Clearly, the maintainer has not heard a certain programming mantra…
- jwaters42 ( @jwaters42@beehaw.org ) 47•9 months ago
After the xz debacle, I think we should resist the temptation to rush maintainers into accepting code that they don’t fully understand.
Yeah, I’m just asking if anyone actually understands this facet.
- towerful ( @towerful@programming.dev ) 23•9 months ago
No you aren’t.
The title is demeaning.
“don’t want to throw shade” as if we all know what’s going on except the people involved in the link.
“Clearly the maintainer hasn’t heard of a certain…” Haha, we are in the same group, right? We know what’s up, guys… Right? Haha, look at these losers.Never mind that you are applying a time pressure on open source maintainers to try and merge a change they don’t understand. Not very respectful. And quite frankly, in extremely bad taste considering the recently revealed xz social engineering.
Where is the question?
There isn’t a single question mark in your post. You frame it as if their problem and they don’t understand.
Even here, where you are so close to asking, you make it sound like you are checking that everyone here understands.Thanks.
- Corbin ( @Corbin@programming.dev ) English3•9 months ago
There is no evidence that any human understands computers.
- Ogeon ( @Ogeon@programming.dev ) 14•9 months ago
A “mantra” more programmers should have is to fix the cause of the issue, and not just the symptoms. You have to understand what the problem is to be able to fix it.
- tyler ( @tyler@programming.dev ) 3•9 months ago
Looks to me like a reasonable conversation is happening trying to find the underlying issue. Where is the PR being held up?
Since I posted it, the conversation has moved forward. Before that it was just two people being justifiably confused.
- Maddier1993 ( @Maddier1993@programming.dev ) 4•9 months ago
You must understand that maintainers need to worry about supply chain attacks ever since the xz debacle. So I suggest you wait.
Thanks. All I wanted was to have someone answer with what’s actually going on, and thanks to Giooschi below that has happened, and there indeed isn’t anything to do at this point. I’ve tried to edit the post but couldn’t find a proper wording.
- Miaou ( @Miaou@jlai.lu ) 2•9 months ago
OP is welcome to use a patched version in their repo and stop harassing maintainers