- mspencer712 ( @mspencer712@programming.dev ) 57•3 months ago
Remove these blank lines.
I’m not seeing unit tests for this.
Unnecessary comment.
BLAM
Ow! Also, this could’ve been a smaller calibur.
- sebsch ( @sebsch@discuss.tchncs.de ) 1•3 months ago
The second one is very valid. Please do not waste my time without having a prove about your functionality.
LGTM (lunatic gunner targeting me)
- ThotDragon ( @thoughtfuldragon@lemmy.blahaj.zone ) English6•3 months ago
it’s me I’m lunatic gunner
- SavvyWolf ( @savvywolf@pawb.social ) English18•3 months ago
“Did you run the formatter on this?”
Bonus points if it’s python code and nowhere in the docs does it say which of the many formatters to use.
- bob_lemon ( @bob_lemon@feddit.org ) 4•3 months ago
Just make another PR where you add formatter instructions to the readme and pyproject.toml.
- Gamma ( @GammaGames@beehaw.org ) English2•3 months ago
Use black and pray
- bob_lemon ( @bob_lemon@feddit.org ) 5•3 months ago
I’m fond of ruff lately. Pretty much the same as black, but it just comes with the linter instead of being separate tools.
- Gamma ( @GammaGames@beehaw.org ) English2•3 months ago
👀 I’d fine-tuned (copied and pasted) a pylint setup that had some of black, what are the differences?
Edit: it’s so much faster than black, I’m switching
Edit2: used it today, faster and I like the linter. It also does some multi-line parentheses better imo
- Hammerheart ( @Hammerheart@programming.dev ) 16•3 months ago
lgtm
lunatic girl threatening me
- AnarchoSnowPlow ( @AnarchoSnowPlow@midwest.social ) 14•3 months ago
Just pull the trigger, we both know how this ends.
Production errors.
- henfredemars ( @henfredemars@infosec.pub ) English12•3 months ago
The number of comments is inversely proportional to the size of the pull request.
- grrgyle ( @grrgyle@slrpnk.net ) 6•3 months ago
Look at that tiny numstat, I’ll finish the review before the CI is even done
- ngn ( @ngn@lemy.lol ) English5•3 months ago
i don’t understand it, am i missing some context here?
- pixelscript ( @pixelscript@lemm.ee ) English15•3 months ago
The meme format implies she catfished you with the promise of “Netflix and chill” at her house only to pull a gun on you.
In particular, she wants you to review and merge that goddamn pull request she made to your open source project repo two months ago that finally fixes that one really annoying bug.
- Midnitte ( @Midnitte@beehaw.org ) English5•3 months ago
Takes on a slightly different meaning in the context of XZ utils
- whoisearth ( @whoisearth@lemmy.ca ) 4•3 months ago
First problem is she’s expecting a right boob like me to review her pull request. Second problem is I don’t give a shit.
- Buttons ( @Buttons@programming.dev ) English3•3 months ago
:+1: