Beehaw
  • Communities
  • Create Post
  • search
    Search
  • Login
  • Sign Up
cute_noker ( cute_noker@feddit.dk )  to Programmer Humor@programming.dev · 1 year ago

is my PR big enough ?

feddit.dk

message-square
13
link
fedilink
121

is my PR big enough ?

feddit.dk

cute_noker ( cute_noker@feddit.dk )  to Programmer Humor@programming.dev · 1 year ago
message-square
13
link
fedilink
alert-triangle
You must log in or # to comment.
  • flamingo_pinyata ( flamingo_pinyata@sopuli.xyz ) 
    link
    fedilink
    arrow-up
    50
    ·
    1 year ago

    Those are rookie numbers

    • pastel_de_airfryer ( pastel_de_airfryer@lemmy.eco.br ) 
      link
      fedilink
      arrow-up
      30
      ·
      1 year ago

      “updated package-lock.json”

  • Eskuero ( eskuero@lemmy.fromshado.ws ) 
    link
    fedilink
    arrow-up
    16
    ·
    1 year ago

    Make sure to send all the code minified to make it small and easier to review.

    • cute_noker ( cute_noker@feddit.dk ) OP
      link
      fedilink
      arrow-up
      3
      ·
      1 year ago

      Minified?

      • 4am ( 4am@lemm.ee ) 
        link
        fedilink
        arrow-up
        8
        ·
        1 year ago

        Tell me you’re not a web developer without telling me you’re not a web developer

        • cute_noker ( cute_noker@feddit.dk ) OP
          link
          fedilink
          arrow-up
          1
          ·
          1 year ago

          Backend

      • syl ( IndieSpren@lemmy.blahaj.zone ) 
        link
        fedilink
        English
        arrow-up
        3
        ·
        1 year ago

        https://en.m.wikipedia.org/wiki/Minification_(programming)

  • BeigeAgenda ( BeigeAgenda@lemmy.ca ) 
    link
    fedilink
    arrow-up
    12
    ·
    1 year ago

    LGTM 👍

  • fckreddit ( fckreddit@lemmy.ml ) 
    link
    fedilink
    arrow-up
    5
    ·
    1 year ago

    These are rookie numbers. Any commit less than 100k lines changed is.

  • hddsx ( hddsx@lemmy.ca ) 
    link
    fedilink
    arrow-up
    4
    ·
    1 year ago

    Because my company works on archaic infrastructure, should PRs be as small as possible with sub-issues sorted into smaller PRs?

    • Lysergid ( Lysergid@lemmy.ml ) 
      link
      fedilink
      arrow-up
      16
      ·
      1 year ago

      PRs should be exactly as big (or small) as task requires. It’s task that needs to be split into smaller task, if it makes sense to split of course.

    • cute_noker ( cute_noker@feddit.dk ) OP
      link
      fedilink
      arrow-up
      3
      ·
      1 year ago

      This took me a month to make. Moving from docker swarm to kubernetes.

      “Containers are platform independent, and can run on anything” - yes… But…

  • onlinepersona ( onlinepersona@programming.dev ) 
    link
    fedilink
    arrow-up
    2
    ·
    1 year ago

    It’s not the size of the PR that counts!

    Anti Commercial-AI license

Programmer Humor@programming.dev

programmer_humor@programming.dev

Subscribe from Remote Instance

Create a post
You are not logged in. However you can subscribe from another Fediverse account, for example Lemmy or Mastodon. To do this, paste the following into the search field of your instance: !programmer_humor@programming.dev

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

  • Keep content in english
  • No advertisements
  • Posts must be related to programming or programmer topics
    • If the mod doesn’t find it funny, you’re banned. Ha-ha!.. For real: do not use the community for “statements”. There are other places for such content. Keep it chill and funny.
Visibility: Public
globe

This community can be federated to other instances and be posted/commented in by their users.

  • 506 users / day
  • 1.73K users / week
  • 3.11K users / month
  • 7.26K users / 6 months
  • 463 local subscribers
  • 33.5K subscribers
  • 1.53K Posts
  • 25.1K Comments
  • Modlog
  • mods:
  • Feyter ( Feyter@programming.dev ) 
  • adr1an ( anzo@programming.dev ) 
  • BurningTurtle ( BurningTurtle@programming.dev ) 
  • Pierre-Yves Lapersonne ( pylapp@programming.dev ) 
  • BE: 0.19.15
  • Modlog
  • Legal
  • Instances
  • Docs
  • Code