• xthexder ( xthexder@l.sw0.com ) 
    link
    fedilink
    arrow-up
    3
    ·
    13 hours ago

    In my opinion, catching a panic is a mistake in the first place. They’re meant to be unrecoverable anyway, so if you want the program to keep running, use Result types or return errors some other way.

    • SorteKanin ( SorteKanin@feddit.dk ) OP
      link
      fedilink
      arrow-up
      2
      ·
      13 hours ago

      Mutex poisoning isn’t really about catching panics. Mutex poisoning happens without any relation to catch_unwind.

      The thing with mutex poisoning is that it is multi-threaded. One thread holds the mutex and panics. It does not catch the panic, the thread simply dies and releases the lock while unwinding. That marks the mutex as poisoned.

      Another thread then tries to get the mutex and sees the poison error. This other thread is still alive since panics do not propogate among all threads. Panics only kill the thread the panic occurs on.

      • xthexder ( xthexder@l.sw0.com ) 
        link
        fedilink
        arrow-up
        2
        ·
        12 hours ago

        I guess I would have thought panic would trigger other threads to abort as well. Admittedly I haven’t really done any multithreading in Rust. I was thinking it was more like exit(status) in C/C++ that immediately terminated the entire process. Exception unrolling in general I feel is something that should be avoided if you care at all about error conditions.

        If panics are isolated to one thread, then I guess mutex poisoning is a better default error case than a deadlock where the process never exits. An entirely independent thread might still be unaware the rest of the program has crashed though.

        • SorteKanin ( SorteKanin@feddit.dk ) OP
          link
          fedilink
          arrow-up
          2
          ·
          10 hours ago

          Panics in Rust default to stack unwinding, which I believe is similar to how exceptions work in C++. I don’t believe an unhandled exception in C++ kills other threads either? Could be wrong.

          Panics can also be configured to instead abort the process immediately, which is the exit(status) way. Obviously with that solution you can never observe a poisoned mutex so you would never need a poisoning mutex in that situation anyway.

          • I don’t believe an unhandled exception in C++ kills other threads either? Could be wrong.

            An unhandled exception in C++ causes the program to call std::terminate, which calls std::abort by default and brings down the entire program. I don’t think there’s a way to prevent an unhandled exception from doing that without causing nasal demons, but I could likewise be wrong. According to the standard, regarding the function function called by std::terminate:

            A std::terminate_handler shall terminate execution of the program without returning to the caller, otherwise the behavior is undefined.

            A quick check suggests that GCC’s std::terminate calls std::abort if your terminate handler does not, but I don’t know if that applies to other implementations