so ill post a few of my failed examples below along with what I came up with as a fix, and then the actual correct code. I feel like im so close to grasping this, but missing some logic. this is for a hangman game.

one of the failed attempts:

import random
word_list = ["aardvark", "baboon", "camel"]
chosen_word = random.choice(word_list)

#Testing code
print(f'Pssst, the solution is {chosen_word}.')

#Create an empty List called display.
#For each letter in the chosen_word, add a "_" to 'display'.
#So if the chosen_word was "apple", display should be ["_", "_", "_", "_", "_"] with 5 "_" representing each letter to guess.


display = ["_"] * len(chosen_word)


guess = input("Guess a letter: ").lower()

#If the letter at that position matches 'guess' then reveal that letter in the display at that position.
#e.g. If the user guessed "p" and the chosen word was "apple", then display should be ["_", "p", "p", "_", "_"].

for letter in chosen_word:
if guess == letter:
for i in range(len(chosen_word)):
display.insert(i, guess)

print(display)

second:

for letter in chosen_word:
  if guess == letter:
    for i in range(len(chosen_word[letter])):
      display.insert(i, guess)

I ended up just saying screw it and went to this:

display = []
for char in chosen_word:
    if guess == letter:
        display += letter
   else:
    display += "_"

correct way of doing it:

import random
word_list = ["aardvark", "baboon", "camel"]
chosen_word = random.choice(word_list)

print(f'Pssst, the solution is {chosen_word}.')

display = []
word_length = len(chosen_word)
for _ in range(word_length):
  display += "_"
print(display)
  
guess = input("Guess a letter: ").lower()


for position in range(word_length):
  letter = chosen_word[position]
  if letter == guess:
    display[position] = letter

print(display)

so as you can see, i get that I can grab specific parts of a list using indices or slices, but somewhere in my brain my logic is wrong. if you guys have struggled with this before or if you have a good youtube video to help me break it down id be beyond thankful!

  •  WillRegex   ( @WillRegex@lemm.ee ) 
    link
    fedilink
    English
    510 months ago

    I think you’re misunderstanding the insert method. insert keeps everything that was already in the list, including the item at the given index. it just shifts part of it to the right to make room for the thing you’re inserting. Directly changing the list using display[position] = letter instead replaces the item at the index with letter.

    Does that make sense?

    • Yeah I figured that one out from the documentation. I with I saved more of my trial and errors so I could show you guys what I needed help with better. I tried the list.insert(x) and then I would do a list.pop(i+1) as well 😂

      I guess what I need help with is I keep messing up where I would put "for x in y: z= y [in position z

      I had a few tries with it written

      For letter in range(len(chosen_word)) : If letter == guess: Display[I] = letter

      But this would grab all the letters and change all blanks to the guess letter

      • Instead of blindly trying code until it works I would suggest you to write on paper the distinct steps that are required to solve the problem.

        Imagine you are the computer and you can do nothing else but what Python allows you. How do you solve the problem ?

        Usually people do this exercise on a small example. Then they generalise the approach when they find examples where it does not work.

  •  RiderExMachina   ( @RiderExMachina@lemmy.ml ) 
    link
    fedilink
    English
    3
    edit-2
    10 months ago

    Having the output of each thing you tried would help us get a feel for where your code was messing up without us having to run it ourselves to get the output.

    That said, for code snippet 1, you’re inserting the letter instead of replacing the underscore with the letter. Not only that, but your for-loop essentially does the following:

    • loop over the length of chosen_word
    • if guess is in the above loop
      • iterate over the display array and add guess that many times (effectively doubling the `display array)

    Your second code snippet does the same thing, but with actual formatting so that Python could run the code.

    I believe your third code snippet introduces char but then returns to letter. It might work if you replaced char with letter again. Also += letter will add the letter to the end of display, which is not what you want to do.

    I did my own version of Hangman in Python a couple years ago if you want to look at the code and see what I did. I’m just a hobbyist, so it’s not fantastic, but it might give you an idea of how someone else has approached the problem.

  • Don’t forget Python’s amazing list comprehension syntax!

    guess = input(“Guess a letter:”).lower()
    display = [ letter if letter == guess else “_” for letter in word ]
    
    

    Just one part of your question, but it saves a lot of futzing around with indices and replaces.

    • Even as an experienced python dev I sometimes prefer explicit for loops over list comprehensions. I think for people who didn’t even grasp the concept of a for loop they are more confusing than helping.

  • I think what tripped you up here is that you iterated over the wrong object. In your second solution:

    for letter in chosen_word:
      if guess == letter:
        for i in range(len(chosen_word[letter])):
          display.insert(i, guess)
    

    while in the correct solution:

    for position in range(word_length):
      letter = chosen_word[position]
      if letter == guess:
        display[position] = letter
    

    The most important difference here is that in your code block, you iterate over the letters, ie. 'a', 'a', 'r', ..., while in the second you iterate over the numerical indices of the string, 0, 1, 2, .... In this specific use case, it’s much easier to use the numerical indices - because you can see how the second code block is using position in two places - once to retrieve the letter from the solution, and then again to update the display when the if condition matches.

    Usually we prefer iteration using the method you used in your solution. But in this case, it’s easier to just iterate by index because you’re retrieving the element from one string, and updating the same position in the other string. You have no way of knowing what position to modify in display unless you have the numerical position, so it’s much easier to iterate that way in this case.

  • This is a pretty compact and - I think - easy to read way of doing it:

    while(display != list(chosen_word)):

    guess = input("Guess a letter: ").lower()

    display = list(map(lambda c, d: c if d != '_' or c == guess else d, chosen_word, display))

    print(display)

    print("Congrats! You did it!")

    Mapping over an array is a pretty powerful tool and also using ternary expressions. If you’re not familiar, a map basically just iterates over an array and runs a function on that item, replacing it with whatever the return value of the function is.

    For example:

    ones = [1, 1] twos = list(map(lambda n: n + 1, ones))

    It’s running the lambda function with n as a parameter and returning n + 1, and it’s pulling the numbers from the array “ones”.

    Then ternary expressions I also find quite powerful. The format of which is basically:

    (result if true) if (condition to check) else (result of false)

    Or:

    2 if 1 + 1 == 2 else "You broke math. How did you do that?"