Remove these blank lines.
I’m not seeing unit tests for this.
Unnecessary comment.
BLAM
Ow! Also, this could’ve been a smaller calibur.
The second one is very valid. Please do not waste my time without having a prove about your functionality.
LGTM (lunatic gunner targeting me)
it’s me I’m lunatic gunner
“Did you run the formatter on this?”
Bonus points if it’s python code and nowhere in the docs does it say which of the many formatters to use.
Just make another PR where you add formatter instructions to the readme and pyproject.toml.
Use black and pray
I’m fond of ruff lately. Pretty much the same as black, but it just comes with the linter instead of being separate tools.
👀 I’d fine-tuned (copied and pasted) a pylint setup that had some of black, what are the differences?
Edit: it’s so much faster than black, I’m switching
Edit2: used it today, faster and I like the linter. It also does some multi-line parentheses better imo
lgtm
lunatic girl threatening me
Just pull the trigger, we both know how this ends.
Production errors.
The number of comments is inversely proportional to the size of the pull request.
Look at that tiny numstat, I’ll finish the review before the CI is even done
i don’t understand it, am i missing some context here?
The meme format implies she catfished you with the promise of “Netflix and chill” at her house only to pull a gun on you.
In particular, she wants you to review and merge that goddamn pull request she made to your open source project repo two months ago that finally fixes that one really annoying bug.
Takes on a slightly different meaning in the context of XZ utils
First problem is she’s expecting a right boob like me to review her pull request. Second problem is I don’t give a shit.
:+1:
